Skip to content

chore: Remove unused deps#16938

Merged
weihanglo merged 2 commits intorust-lang:masterfrom
epage:deps
Apr 24, 2026
Merged

chore: Remove unused deps#16938
weihanglo merged 2 commits intorust-lang:masterfrom
epage:deps

Conversation

@epage
Copy link
Copy Markdown
Contributor

@epage epage commented Apr 24, 2026

What does this PR try to resolve?

Likely won't make an impact to build times since these dependencies are still used somewhere but they at least make things clearer. Maybe people using these crates as libraries can benefit.

How to test and review this PR?

As found by

CARGO_LOG=cargo::core::compiler::unused_deps=debug nargo check --workspace

As found by
```
CARGO_LOG=cargo::core::compiler::unused_deps=debug nargo check --workspace
```
@rustbot rustbot added A-dependency-resolution Area: dependency resolution and the resolver A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-testing-cargo-itself Area: cargo's tests Command-fix labels Apr 24, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 24, 2026

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, weihanglo

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2026
Copy link
Copy Markdown
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start dogfooding ourselves with -Zcargo-lints?

BTW, free free to merge when CI is green.

View changes since this review

@epage
Copy link
Copy Markdown
Contributor Author

epage commented Apr 24, 2026

The bump check is a non-blocking job currently broken by GitoxideLabs/gitoxide#2541 because cargo-semver-checks isn't able to respect lockfiles fully.

@weihanglo weihanglo added this pull request to the merge queue Apr 24, 2026
Merged via the queue into rust-lang:master with commit eb9b60f Apr 24, 2026
30 of 31 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2026
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Apr 25, 2026
Update cargo submodule

10 commits in 06ac0e7c05770a8c7bbf67bdd12fa1a1eefdc8ae..eb9b60f1f6604b5e022c56be31692c215b8ba11d
2026-04-21 15:33:56 +0000 to 2026-04-24 20:52:07 +0000
- chore: Remove unused deps (rust-lang/cargo#16938)
- feat(compile): Stabilize `build.warnings` (rust-lang/cargo#16796)
- cargo clean: do not error if explicitly specified target-dir does not exist (rust-lang/cargo#16934)
- Revert "feat(lints): Add unused deps ignore list" (rust-lang/cargo#16937)
- fix(compile): Ignore unused deps if also transitive  (rust-lang/cargo#16935)
- Update rustls (rust-lang/cargo#16932)
- chore(deps): update rust crate openssl to v0.10.78 [security] (rust-lang/cargo#16931)
- chore(build-rs): Ensure we lint the crate (rust-lang/cargo#16930)
- Fix flaky test: proc_macro_in_artifact_dep (rust-lang/cargo#16922)
- refactor(compile): Log all ignored unused externs (rust-lang/cargo#16920)

r? ghost
@rustbot rustbot added this to the 1.97.0 milestone Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-dependency-resolution Area: dependency resolution and the resolver A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-testing-cargo-itself Area: cargo's tests Command-fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants