fix(compile): Ignore unused deps if also transitive #16935
Merged
arlosi merged 3 commits intorust-lang:masterfrom Apr 23, 2026
Merged
fix(compile): Ignore unused deps if also transitive #16935arlosi merged 3 commits intorust-lang:masterfrom
arlosi merged 3 commits intorust-lang:masterfrom
Conversation
This is to ensure these tests still have the intended coverage regardless of how we work around unused direct deps that are present to control their transitive presence.
This is to reduce false positives without having to ignore them. In fact, I plan to revert support for `ignore` after this change.
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @ehuss rustbot has assigned @ehuss. Use Why was this reviewer chosen?The reviewer was selected based on:
|
arlosi
approved these changes
Apr 23, 2026
rustbot
removed
the
S-waiting-on-review
pull Bot
pushed a commit
to Mu-L/cargo
that referenced
this pull request
Apr 23, 2026
This reverts commit b276acc. This is a follow up to rust-lang#16935 where we take a different direction for false positives. Instead of an allowlist, we will ignore unused direct deps that are also transitive deps (technically still used somewhere). This leaves workflows like `curl` where the `build.rs` dynamically decides what deps to use but that seems like enough of an exception case to not worry about direct integration for.
pull Bot
pushed a commit
to Mu-L/cargo
that referenced
this pull request
Apr 23, 2026
### What does this PR try to resolve? This is a follow up to rust-lang#16935 where we take a different direction for false positives. We are now ignoring unused direct deps that are also transitive deps (technically still used somewhere). This leaves workflows like `curl` where the `build.rs` dynamically decides what deps to use but that seems like enough of an exception case to not worry about direct integration for. This means we can punt on having an allowlist to decide what approach we want take from among rust-lang/rfcs#3920 ### How to test and review this PR? This reverts commit b276acc.
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Apr 25, 2026
Update cargo submodule 10 commits in 06ac0e7c05770a8c7bbf67bdd12fa1a1eefdc8ae..eb9b60f1f6604b5e022c56be31692c215b8ba11d 2026-04-21 15:33:56 +0000 to 2026-04-24 20:52:07 +0000 - chore: Remove unused deps (rust-lang/cargo#16938) - feat(compile): Stabilize `build.warnings` (rust-lang/cargo#16796) - cargo clean: do not error if explicitly specified target-dir does not exist (rust-lang/cargo#16934) - Revert "feat(lints): Add unused deps ignore list" (rust-lang/cargo#16937) - fix(compile): Ignore unused deps if also transitive (rust-lang/cargo#16935) - Update rustls (rust-lang/cargo#16932) - chore(deps): update rust crate openssl to v0.10.78 [security] (rust-lang/cargo#16931) - chore(build-rs): Ensure we lint the crate (rust-lang/cargo#16930) - Fix flaky test: proc_macro_in_artifact_dep (rust-lang/cargo#16922) - refactor(compile): Log all ignored unused externs (rust-lang/cargo#16920) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This changes
unused_dependencieslint to reduce the chance of false positives while we work out the story of how we want people to response to false positives (rust-lang/rfcs#3920).How to test and review this PR?
My assumption is that I will revert the
ignorelint control added in #16600 after this.Looking at the known cases of false positives, my short term plan is:
build.rsincurl): users mustallowLonger term, I'd like to replace this change with either
lib = falsefrom artifact depscfg(resolver = "versions"), #t-cargo > Additional dependency tables @ 💬We can evolve this because the exact nature of warning-by-default lints is not stable.