cargo clean: do not error if explicitly specified target-dir does not exist#16934
Merged
weihanglo merged 2 commits intorust-lang:masterfrom Apr 23, 2026
Merged
cargo clean: do not error if explicitly specified target-dir does not exist#16934weihanglo merged 2 commits intorust-lang:masterfrom
weihanglo merged 2 commits intorust-lang:masterfrom
Conversation
…target-dir does not exist
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
weihanglo
approved these changes
Apr 23, 2026
Comment on lines
+77
to
+79
| if target_dir_path.exists() { | ||
| // check if the target directory has a valid CACHEDIR.TAG | ||
| if let Err(err) = validate_target_dir_tag(target_dir_path) { |
Member
There was a problem hiding this comment.
nit: we can collapse this with if-let chain maybe?
Suggested change
| if target_dir_path.exists() { | |
| // check if the target directory has a valid CACHEDIR.TAG | |
| if let Err(err) = validate_target_dir_tag(target_dir_path) { | |
| // and check if the target directory has a valid CACHEDIR.TAG | |
| if target_dir_path.exists() && let Err(err) = validate_target_dir_tag(target_dir_path) { |
TanmayArya-1p
force-pushed
the
target-dir-noop
branch
from
5774dc4 to
587a8a2
Compare
Member
|
Thanks! |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Apr 25, 2026
Update cargo submodule 10 commits in 06ac0e7c05770a8c7bbf67bdd12fa1a1eefdc8ae..eb9b60f1f6604b5e022c56be31692c215b8ba11d 2026-04-21 15:33:56 +0000 to 2026-04-24 20:52:07 +0000 - chore: Remove unused deps (rust-lang/cargo#16938) - feat(compile): Stabilize `build.warnings` (rust-lang/cargo#16796) - cargo clean: do not error if explicitly specified target-dir does not exist (rust-lang/cargo#16934) - Revert "feat(lints): Add unused deps ignore list" (rust-lang/cargo#16937) - fix(compile): Ignore unused deps if also transitive (rust-lang/cargo#16935) - Update rustls (rust-lang/cargo#16932) - chore(deps): update rust crate openssl to v0.10.78 [security] (rust-lang/cargo#16931) - chore(build-rs): Ensure we lint the crate (rust-lang/cargo#16930) - Fix flaky test: proc_macro_in_artifact_dep (rust-lang/cargo#16922) - refactor(compile): Log all ignored unused externs (rust-lang/cargo#16920) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16925
Regressed in #16712 which added validation for explicitly specified target directories by checking if they contain a valid
CACHEDIR.TAG.This PR makes it so that cargo skips this validation if the target-dir doesn't exist.