feat: treating required-feature as default feature for cli#16852
feat: treating required-feature as default feature for cli#16852cathaysia wants to merge 1 commit intorust-lang:masterfrom
Conversation
fix rust-lang#4663 Signed-off-by: loongtao.zhang <loongtao.zhang@outlook.com>
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
I'm going to close this pending design discussions per our contrib guide. #4663 is marked as |
|
I noticed that issue dates back about nine years, and there doesn't seem to have been any significant progress. Is there really any chance of further progress? |
|
I have no objections to the process itself; however, given that it has been shelved for so long—and rather than getting bogged down in endless disputes—why not implement a version first to see what the response is? |
|
Please see #4663 (comment) and the RFC rust-lang/rfcs#3374. There are some technical and design problems needing to resolve and experiment.
I am not sure whether your first version referring to a stable version or not. A PR that aims for insta-stable is unlikely to get merge. Cargo follows a strong compatibility guarantee. That said, you are welcome to experiment and if it is working good we can start from a nightly feature. |
What does this PR try to resolve?
fix #4663
This PR changes the semantics of
required-featuresfor binary targets, treating them as default features. When--no-default-featuresis not specified, the features listed inrequired-featuresare automatically enabled.How to test and review this PR?