Conversation
senekor
force-pushed
the
senekor/uomotnwuqlun
branch
from
6200c3b to
7d5c487
Compare
Manishearth
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1796
supersedes #1797
I ended up using
night-owl-lightinstead oflight-plus. light-plus had some unpleasant contrasts in many places. I imagine those would be bad for accessibility as well. night-owl-light seems more pleasant to me, with a consistently good contrast. But I don't have much experience with accessibility. So I'm happy to change the theme if we get feedback that it's hard to read for some people.I've created a snapshot of the output before and after:
b34eed9
The diff is pretty big and I can't claim to have read it all, but during my skimming I only noticed changes that are expected / fine:
rel="external"The source of the night-owl-light theme is here:
https://github.com/shikijs/textmate-grammars-themes/blob/8f259c229f4f32393daee63a3fda32cbe1af307a/packages/tm-themes/themes/night-owl-light.json
(MIT licensed)