Use package.include to remove the reference implementation which isn't necessary for building#29
Open
42triangles wants to merge 1 commit intorust-lang:mainfrom
Open
Use package.include to remove the reference implementation which isn't necessary for building#2942triangles wants to merge 1 commit intorust-lang:mainfrom
42triangles wants to merge 1 commit intorust-lang:mainfrom
Conversation
…t necessary for building This decreases the packaged size to less than half: | | # of files | uncompressed | compressed | | ---------------------- | ---------- | ---------------- | --------------- | | before | 35 | 355.5KiB | 82.9KiB | | with `package.include` | 15 (42.9%) | 122.9KiB (34.6%) | 30.1KiB (36.3%) | | with tests¹ | 20 (57.1%) | 166.5KiB (46.9%) | 37.4KiB (45.1%) | And beyond that allows easier dependency reviews (though that is in this case much less important since everything `rust-lang` is likely trusted anyways) This now includes (output from `cargo package --list`): ``` .cargo_vcs_info.json Cargo.lock Cargo.toml Cargo.toml.orig LICENSE.txt Readme.md src/alignment.rs src/archive.rs src/archive_writer.rs src/coff.rs src/coff_import_file.rs src/lib.rs src/mangler.rs src/math_extras.rs src/object_reader.rs ``` ¹ Using the version below (which includes tests as well): ```rust include = ["/src", "/tests", "/LICENSE.txt", "/Readme.md"] ``` The additionally included files would be: ``` tests/common.rs tests/import_library.def tests/import_library.rs tests/multiple_objects.rs tests/round_trip.rs ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This decreases the packaged size to less than half:
package.includeAnd beyond that allows easier dependency reviews (though that is in this
case much less important since everything
rust-langis likely trustedanyways)
This now includes (output from
cargo package --list):¹ Using the version below (which includes tests as well):
The additionally included files would be: