Skip to content

riscv-macros: Move entry attribute macro#388

Closed
romancardenas wants to merge 2 commits into
riscv-macrosfrom
riscv-macros-entry
Closed

riscv-macros: Move entry attribute macro#388
romancardenas wants to merge 2 commits into
riscv-macrosfrom
riscv-macros-entry

Conversation

@romancardenas
Copy link
Copy Markdown
Contributor

This PR is a continuation of #386 . It moves the entry macro from riscv-rt-macros to riscv-macros.

It also serves as an example of how the new macro refactoring allows us to reuse the code for all the attributes, easing the maintenance efforts.

@romancardenas romancardenas requested a review from a team as a code owner January 16, 2026 11:34
Copy link
Copy Markdown
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@romancardenas romancardenas force-pushed the riscv-macros branch 4 times, most recently from 79c47a6 to 8049a7f Compare January 23, 2026 20:22
@romancardenas
Copy link
Copy Markdown
Contributor Author

@MabezDev can you check #386 and let me know if the new error handling is compatible with esp-riscv-rt? It should be, but just in case.

@romancardenas
Copy link
Copy Markdown
Contributor Author

closing in favor of #386

@romancardenas romancardenas deleted the riscv-macros-entry branch May 4, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants