Skip to content

Remove more nightly Rust. #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathanpallant wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −12
Open

Remove more nightly Rust. #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ jobs:
uses: taiki-e/install-action@just
- name: Install Rust
run: |
rustup install nightly-2026-02-26
rustup component add rust-src --toolchain nightly-2026-02-26
rustup default nightly-2026-02-26
rustup install stable
rustup default stable
rustup component add rust-src
- name: Build
run: |
just build-tier3 ${{ matrix.target }}
Copy link
Copy Markdown
Contributor

@robamu robamu Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we re-name those targets?

Copy link
Copy Markdown
Contributor

@thejpster thejpster Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename what targets?

Copy link
Copy Markdown
Contributor

@thejpster thejpster Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the github job name? The targets remain at Tier 3 (and hence technically 'nightly only) - I'm building them on stable because RUSTC_BOOTSTRAP=1 is set at the top of the justfile.

Expand All @@ -89,9 +89,9 @@ jobs:
uses: taiki-e/install-action@just
- name: Install Rust
run: |
rustup install nightly-2026-02-26
rustup component add rust-src --toolchain nightly-2026-02-26
rustup default nightly-2026-02-26
rustup install stable
rustup default stable
rustup component add rust-src
- name: Build
run: |
just build-tier3-no-atomics ${{ matrix.target }}
Copy link
Copy Markdown
Contributor

@robamu robamu Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Expand Down
11 changes: 5 additions & 6 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export RUSTC_BOOTSTRAP := "1"
# If you run with `just --set v 1` then we make cargo run in verbose mode
v := "0"
verbose := if v == "1" { "--verbose" } else { "" }
nightly := "nightly-2026-02-26"

# Our default target. It does everything that you might want to do pre-checkin.
check: build-all build-all-examples fmt-check clippy-examples clippy-targets clippy-host test
Expand Down Expand Up @@ -57,14 +56,14 @@ build-arm-targets:

# Builds our workspace with various features, building core from source, but skipping anything that requires atomics
build-tier3-no-atomics target:
cargo +{{nightly}} build --target {{target}} -Zbuild-std=core {{verbose}}
cargo +{{nightly}} build --target {{target}} -Zbuild-std=core --features "serde, defmt, critical-section-single-core, check-asm" {{verbose}}
cargo build --target {{target}} -Zbuild-std=core {{verbose}}
cargo build --target {{target}} -Zbuild-std=core --features "serde, defmt, critical-section-single-core, check-asm" {{verbose}}

# Builds our workspace with various features, building core from source
build-tier3 target:
cargo +{{nightly}} build --target {{target}} -Zbuild-std=core {{verbose}}
cargo +{{nightly}} build --target {{target}} -Zbuild-std=core --features "serde, defmt, critical-section-multi-core, check-asm" {{verbose}}
cargo +{{nightly}} build --target {{target}} -Zbuild-std=core --features "serde, defmt, critical-section-single-core, check-asm" {{verbose}}
cargo build --target {{target}} -Zbuild-std=core {{verbose}}
cargo build --target {{target}} -Zbuild-std=core --features "serde, defmt, critical-section-multi-core, check-asm" {{verbose}}
cargo build --target {{target}} -Zbuild-std=core --features "serde, defmt, critical-section-single-core, check-asm" {{verbose}}

# Builds our workspace with various features
build-tier2 target:
Expand Down
Loading