feat: bubble up wait for status errors#3
Merged
zeldan merged 2 commits intorust-dd:mainfrom May 2, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While getting a DHT-11 working with esp-hal v1.0.0-beta.0, I noticed that
read()would never return when using the published crate. When I switched to using a local clone of my fork, it started returning 0s for temperature and humidity rather than throwing an error. Withmatchclauses inwait_for_state, it returnedTimeouterrors instead.This PR adds those match clauses for timeout and pin errors to
wait_for_stateand adds tests for those errors. VS Code automatically addressed a few linter nits as well.