Remove bitcoin for secp256k1 with no-std fix#157
Merged
nyonson merged 1 commit intorust-bitcoin:mainfrom Sep 6, 2025
Merged
Conversation
To help with type safety a bit, I have public callsites use an `impl Borrow<[u8; 4]>`, which the `p2p::Magic` type implements. This way one can pass magic variables directly. In the handshake this just gets dereferenced anyway, but it still feels more ergonomic than forcing a `to_bytes` on the caller IMO. I keep the `secp256k1` the same, but maybe it can be bumped. I forget if there are problems when attempting to build conflicting versions or not. Concat usage was dropped in favor of explicit array handling. This was probably being iron'd out by the compiler before, but this patch introduces Borrow which broke no-std environment support. Co-authored-by: Nick Johnson <nick@yonson.dev>
Collaborator
|
ACK 0aecda7 I'll let you do the honors on merging. Yeah, I think we just match |
rustaceanrob
approved these changes
Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #156 with a no-std fix and doc fixes (maybe there is a better way to do this than a new PR, but my git-foo is lacking here).
@rustaceanrob should we try to lower the version of secp for flexibility or is there a reason to set the bar at v0.29.0? EDIT: guess we should just match
bitcointo not cause a multiple versions for consumers.