Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/sidecar-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: "22.12.0"
node-version: "24.18.0"
cache: npm

- uses: actions/setup-python@v5
Expand Down
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22.20.0
24.18.0
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22.20.0
24.18.0
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ Rowing Tracker is a modern, AI-powered web app built specifically for rowers who

### Prerequisites

- Node.js 22.12+
- Node.js 24+
- npm 10.8+
- Docker & Docker Compose (for local development)
- OpenAI API Key (optional, for AI features)
Expand Down
167 changes: 69 additions & 98 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"homepage": "https://github.com/rupertgermann/rowing-tracker",
"packageManager": "npm@10.9.3",
"engines": {
"node": ">=22.12.0",
"node": ">=24.0.0",
"npm": ">=10.8.0"
},
"scripts": {
Expand Down Expand Up @@ -90,7 +90,7 @@
"devDependencies": {
"@tailwindcss/postcss": "^4",
"@types/bcryptjs": "^2.4.6",
"@types/node": "^20",
"@types/node": "^24",
"@types/nodemailer": "^8.0.0",
"@types/papaparse": "^5.5.0",
"@types/pg": "^8.16.0",
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-node-version.mjs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const minimum = [22, 12, 0];
const minimum = [24, 0, 0];
const current = process.versions.node.split(".").map(Number);

let isSupported = true;
Expand Down
29 changes: 29 additions & 0 deletions tests/nodeRuntimeVersion.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import assert from "node:assert/strict";
import { readFileSync } from "node:fs";
import path from "node:path";
import { test } from "node:test";
import { fileURLToPath } from "node:url";

const repositoryRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
const expectedNodeVersion = "24.18.0";

function readRepositoryFile(filePath: string): string {
return readFileSync(path.join(repositoryRoot, filePath), "utf8");
}

test("Node 24 is used consistently across local, app, and CI runtimes", () => {
assert.equal(readRepositoryFile(".nvmrc").trim(), expectedNodeVersion);
assert.equal(readRepositoryFile(".node-version").trim(), expectedNodeVersion);

const packageJson = JSON.parse(readRepositoryFile("package.json"));
assert.equal(packageJson.engines.node, ">=24.0.0");

assert.match(
readRepositoryFile("scripts/check-node-version.mjs"),
/const minimum = \[24, 0, 0\];/
);
assert.match(
readRepositoryFile(".github/workflows/sidecar-release.yml"),
/node-version: "24\.18\.0"/
);
});
Loading