feat(ai-assistants): add CRUD operations for AI assistants (personas)#13
Open
stewartshea wants to merge 1 commit into
Open
feat(ai-assistants): add CRUD operations for AI assistants (personas)#13stewartshea wants to merge 1 commit into
stewartshea wants to merge 1 commit into
Conversation
- Introduced new tools for managing AI assistants, including `list_assistants`, `get_assistant`, `create_assistant`, `update_assistant`, and `delete_assistant`. - Updated documentation in AGENTS.md and README.md to reflect the new functionality and usage. - Enhanced authorization checks to include the new assistant management tools. - Added validation for assistant names to ensure compliance with naming conventions. - Implemented unit tests for the new assistant management features to ensure reliability.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c93a178. Configure here.
| except (ValueError, httpx.HTTPStatusError) as e: | ||
| return _json_response({"error": str(e)}) | ||
|
|
||
|
|
There was a problem hiding this comment.
HTTP mode missing assistant tools
High Severity
The five new assistant MCP tools are registered on the stdio mcp instance via @mcp.tool(), but they were not added to _TOOL_FUNCTIONS. Remote HTTP mode builds its server only from that list, so list/get/create/update/delete_assistant are unavailable there and never get workspace auth checks.
Reviewed by Cursor Bugbot for commit c93a178. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


list_assistants,get_assistant,create_assistant,update_assistant, anddelete_assistant.Note
Medium Risk
Introduces workspace write APIs that can replace full persona config on upsert and affect chat behavior via persona_name; gated to readwrite+ but mis-use of create_assistant could reset settings.
Overview
This PR adds first-class MCP support for workspace AI assistants (personas) so agents can create and manage dedicated
persona_nameidentities forworkspace_chat, not only workspace-wide chat rules/commands.Server: Five new tools —
list_assistants,get_assistant,create_assistant,update_assistant,delete_assistant— call PAPI v4/personas(list/get/delete) and/personas/sync-typed(create/update). Assistantshort_namemaps topersona_name; full platform names use{workspace}--{short_name}.create_assistantis a full upsert (omitted fields reset);update_assistantfetch-merge-writes partial changes. Kebab-case name validation blocks--(workspace/persona separator). Mutations are gated viaWRITE_TOOLS(readwrite+).Docs & workflow:
AGENTS.md,README.md, and Copilot instructions document the tools; newcreate-ai-assistantskill walks through persona-scoped rules/commands and verification.Tests: Tool schema lists, validation/unit tests for names and
WRITE_TOOLSmembership.Reviewed by Cursor Bugbot for commit c93a178. Bugbot is set up for automated code reviews on this repo. Configure here.