Skip to content

demo: delete the spot NodePool, which runs 2 nodes (expect nodepool-deleted-with-nodes) — DO NOT MERGE - #25

Closed
pvishwa3 wants to merge 2 commits into
demo/karpenter-basefrom
demo/karpenter-deleted-with-nodes
Closed

pvishwa3 wants to merge 2 commits into
demo/karpenter-basefrom
demo/karpenter-deleted-with-nodes

Conversation

@pvishwa3

@pvishwa3 pvishwa3 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Live demo of wrs-addon-karpenter-nodepool-deleted-with-nodes. Base is demo/karpenter-base (the live rtz-eks spot NodePool, verbatim), not main, so Argo never applies either side.

On rtz-eks spot has 2 NodeClaims. Deleting the NodePool should report that both nodes are deleted with it. Do not merge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014NPEGf1kUYALnqg7HFRtBH
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Deployment risk: HIGH (score 61) — 2 findings

Severity Rule Resource Title
MEDIUM mrs-diff-resource-removed NodePool/spot Resource removed from manifest

Add-on findings · Karpenter (1)

Severity Rule Resource Title
HIGH wrs-addon-karpenter-nodepool-deleted-with-nodes NodePool/spot Deleting a NodePool that still runs nodes
What changed and how to fix it
  • mrs-diff-resource-removed · NodePool/spot — NodePool spot was removed from the manifest. Verify this deletion is intentional.
    Fix: A resource present in the base manifest is absent in the head. Verify this deletion is intentional and that no other workloads depend on it.
  • wrs-addon-karpenter-nodepool-deleted-with-nodes · NodePool/spot — NodePool spot: The change deletes this NodePool, which runs 2 node(s) now. Every NodeClaim carries a blocking owner reference to its NodePool, so Kubernetes deletes all 2 node(s) with it: Karpenter drains them (respecting PodDisruptionBudgets) and terminates the instances. Pods that fit another NodePool move there; the rest stay Pending.
    Fix: NodeClaims are owned by their NodePool, so deleting it deletes every node it launched. Move workloads to another NodePool first (or let them move: they need one they fit), then delete it.

Cluster-aware checks: on — 53 runtimez lookup(s) answered.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014NPEGf1kUYALnqg7HFRtBH
@pvishwa3

pvishwa3 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Live demo done: nodepool-deleted-with-nodes fired HIGH on action 1.0.18 (after eac#616). Closing (DO NOT MERGE).

@pvishwa3 pvishwa3 closed this Nov 9, 2026
@pvishwa3
pvishwa3 deleted the demo/karpenter-deleted-with-nodes branch November 9, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant