Skip to content

demo: spot NodePool limits.cpu 16 -> 4, below the 6 CPU it runs (expect nodepool-limits-below-usage) — DO NOT MERGE - #24

Closed
pvishwa3 wants to merge 1 commit into
demo/karpenter-basefrom
demo/karpenter-limits-below-usage
Closed

pvishwa3 wants to merge 1 commit into
demo/karpenter-basefrom
demo/karpenter-limits-below-usage

Conversation

@pvishwa3

@pvishwa3 pvishwa3 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Live demo of wrs-addon-karpenter-nodepool-limits-below-usage. Base is demo/karpenter-base (the live rtz-eks spot NodePool, verbatim), not main, so Argo never applies either side.

On rtz-eks spot runs 6 CPU / 2 nodes under limits.cpu 16. Lowering the limit to 4 should report the pool as being at or below what it already uses. Do not merge.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Deployment risk: HIGH (score 61) — 1 finding

Add-on findings · Karpenter (1)

Severity Rule Resource Title
HIGH wrs-addon-karpenter-nodepool-limits-below-usage NodePool/spot NodePool limit set at or below what the pool already uses
What changed and how to fix it
  • wrs-addon-karpenter-nodepool-limits-below-usage · NodePool/spot — NodePool spot: The change sets limits at or below what the pool already runs: cpu 4 (in use now: 6, limit today 16). Karpenter launches no new node for this NodePool once a limit is reached, so pods that need a new node here stay Pending. Existing nodes are not removed: Karpenter does not scale a pool down to a lowered limit.
    Fix: Karpenter launches no new node for a NodePool at its limit, and does not remove nodes to get under a lowered one. Keep the limit above current usage plus the headroom new pods and drift replacements need.

Cluster-aware checks: on — 53 runtimez lookup(s) answered.

@pvishwa3

pvishwa3 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Live demo done: nodepool-limits-below-usage fired HIGH on action 1.0.17. Closing (DO NOT MERGE).

@pvishwa3 pvishwa3 closed this Nov 9, 2026
@pvishwa3
pvishwa3 deleted the demo/karpenter-limits-below-usage branch November 9, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant