Skip to content

gate-web: switch TLS to letsencrypt-prod + ECDSA, add www cert (DO NOT MERGE) - #18

Closed
pvishwa3 wants to merge 1 commit into
mainfrom
pr/cert-manager-risky
Closed

pvishwa3 wants to merge 1 commit into
mainfrom
pr/cert-manager-risky

Conversation

@pvishwa3

@pvishwa3 pvishwa3 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Deliberately risky cert-manager change, to show the deployment-risk gate blocking a PR:

  • Certificate gate-web-tls issuerRef → ClusterIssuer letsencrypt-prod (does not exist on the cluster)
  • private key RSA 2048 → ECDSA 256 with rotationPolicy: Never
  • a second Certificate gate-web-www-tls writing the same Secret gate-web-tls

Expected gate: HIGH, blocked. Do not merge.

🤖 Generated with Claude Code

https://claude.ai/code/session_014NPEGf1kUYALnqg7HFRtBH

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

Deployment risk: HIGH (score 61) — 5 findings

Severity Rule Resource Title
INFO mrs-diff-resource-added Certificate/rtz-gate-demo/gate-web-www-tls Resource added to manifest

Add-on findings · cert-manager (4)

Severity Rule Resource Title
HIGH wrs-addon-cert-manager-issuer-ref-missing Certificate/rtz-gate-demo/gate-web-tls cert-manager certificate names an issuer that does not exist
HIGH wrs-addon-cert-manager-duplicate-secret-name Certificate/rtz-gate-demo/gate-web-tls Two cert-manager Certificates write the same Secret
MEDIUM wrs-addon-cert-manager-certificate-issuer-changed Certificate/rtz-gate-demo/gate-web-tls cert-manager Certificate moves to another issuer
HIGH wrs-addon-cert-manager-private-key-changed Certificate/rtz-gate-demo/gate-web-tls cert-manager Certificate private key spec changes
What changed and how to fix it
  • mrs-diff-resource-added · Certificate/rtz-gate-demo/gate-web-www-tls — Certificate rtz-gate-demo/gate-web-www-tls was added to the manifest.
    Fix: A new resource is present in the head manifest that was not in the base. Informational: verify the addition is intentional.
  • wrs-addon-cert-manager-issuer-ref-missing · Certificate/rtz-gate-demo/gate-web-tls — Certificate rtz-gate-demo/gate-web-tls: spec.issuerRef names ClusterIssuer letsencrypt-prod, which is neither in this change nor on the cluster. The certificate is never issued; a renewal of an existing one stalls until the issuer exists.
    Fix: Create the Issuer / ClusterIssuer the Certificate (or the Ingress's cert-manager.io/issuer / cluster-issuer annotation) names, in the same change or before it, or point it at one that exists. cert-manager waits for the issuer: the certificate is never issued, and an existing one stops renewing.
  • wrs-addon-cert-manager-duplicate-secret-name · Certificate/rtz-gate-demo/gate-web-tls — Certificate rtz-gate-demo/gate-web-tls: Certificates gate-web-tls, gate-web-www-tls all write Secret rtz-gate-demo/gate-web-tls. Each issuance overwrites the other's, so cert-manager re-issues them against each other without end — a CertificateRequest storm that can exhaust an ACME rate limit.
    Fix: Give each Certificate its own spec.secretName. With two Certificates on one Secret each issuance overwrites the other's, cert-manager re-issues them against each other without end, and the CertificateRequest storm can exhaust an ACME CA's rate limits.
  • wrs-addon-cert-manager-certificate-issuer-changed · Certificate/rtz-gate-demo/gate-web-tls — Certificate rtz-gate-demo/gate-web-tls: issuerRef changes from Issuer demo-selfsigned to ClusterIssuer letsencrypt-prod. cert-manager re-issues it from the new issuer straight away, so the served chain (and its root) changes on merge, not at the next renewal: clients that trust only the old CA fail.
    Fix: Make sure every client trusts the new issuer's CA before merging. cert-manager re-issues the certificate from the new issuer immediately, so the served chain changes at merge time, not at the next renewal.
  • wrs-addon-cert-manager-private-key-changed · Certificate/rtz-gate-demo/gate-web-tls — Certificate rtz-gate-demo/gate-web-tls: the private key spec changes (algorithm RSA → ECDSA, size 2048 → 256). With rotationPolicy: Never cert-manager may not generate a new key, and the existing one no longer matches: issuance stops ("User intervention required") and the certificate is never renewed until the policy or the key changes.
    Fix: With rotationPolicy: Never cert-manager cannot create a key that matches the new spec, and issuance stops until rotationPolicy is Always or the old Secret's key is replaced. With Always (the 1.18+ default) the certificate is re-issued at once with a new key: update anything that pins the public key first.

Cluster-aware checks: on — 51 runtimez lookup(s) answered.

@pvishwa3

pvishwa3 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Closing: demo of a blocked cert-manager change (gate HIGH 61). Not meant to merge.

@pvishwa3 pvishwa3 closed this Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant