Added variants of 3 tests with 3 (MAX_SIGNERS) signers#188
Merged
automergerpr-permission-manager[bot] merged 5 commits intoproofsfrom Apr 9, 2026
Merged
Added variants of 3 tests with 3 (MAX_SIGNERS) signers#188automergerpr-permission-manager[bot] merged 5 commits intoproofsfrom
automergerpr-permission-manager[bot] merged 5 commits intoproofsfrom
Conversation
Stevengre
approved these changes
Apr 7, 2026
Stevengre
left a comment
There was a problem hiding this comment.
We can merge it for speed. But I'm wondering if there any other better options.
dkcumming
approved these changes
Apr 7, 2026
Author
|
EDIT: Removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 3 test variants
test_process_approve_multisig_3sigtest_process_revoke_multisig_3sigtest_process_withdraw_excess_lamports_multisig_multisig_3sigwhich are the same as the
test_process_approve_multisigtest_process_revoke_multisigtest_process_withdraw_excess_lamports_multisig_multisigexcept with 3 signers instead of 1. The reasoning is to choose a small number of proofs to be completed with 3 signers. These are not large and do not have multiple calls to
validate_owner, so they should be manageable, and have different operations. On top of thetest_process_initialize_multisigthat already has 3, we will be doing 4/20.