Skip to content

Added variants of 3 tests with 3 (MAX_SIGNERS) signers#188

Merged
automergerpr-permission-manager[bot] merged 5 commits intoproofsfrom
mk/3sig-versions
Apr 9, 2026
Merged

Added variants of 3 tests with 3 (MAX_SIGNERS) signers#188
automergerpr-permission-manager[bot] merged 5 commits intoproofsfrom
mk/3sig-versions

Conversation

@mariaKt
Copy link
Copy Markdown

@mariaKt mariaKt commented Apr 6, 2026

This PR adds 3 test variants

  • test_process_approve_multisig_3sig
  • test_process_revoke_multisig_3sig
  • test_process_withdraw_excess_lamports_multisig_multisig_3sig

which are the same as the

  • test_process_approve_multisig
  • test_process_revoke_multisig
  • test_process_withdraw_excess_lamports_multisig_multisig
    except with 3 signers instead of 1. The reasoning is to choose a small number of proofs to be completed with 3 signers. These are not large and do not have multiple calls to validate_owner, so they should be manageable, and have different operations. On top of the test_process_initialize_multisig that already has 3, we will be doing 4/20.

@mariaKt mariaKt marked this pull request as ready for review April 6, 2026 21:06
@mariaKt mariaKt requested review from Stevengre and dkcumming April 6, 2026 21:06
Copy link
Copy Markdown

@Stevengre Stevengre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge it for speed. But I'm wondering if there any other better options.

@mariaKt
Copy link
Copy Markdown
Author

mariaKt commented Apr 9, 2026

EDIT: Removing test_process_approve_multisig_3sig.
These tests' proofs are very large, so I decided to only add two instead of three.

@automergerpr-permission-manager automergerpr-permission-manager Bot merged commit 12a1fd3 into proofs Apr 9, 2026
2 checks passed
@mariaKt mariaKt deleted the mk/3sig-versions branch April 9, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants