Repository navigation
fix(chat-export): redact PEM private keys and trigger lab CI (#20 follow-up) - #21
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow up on the two P2 findings raised after #20 was merged:
opc-lab.ymlpath filter, so fixture tests could be skipped.Changes
BEGIN ... PRIVATE KEY/END ... PRIVATE KEYblocks before export, including PKCS#8, RSA, EC, OpenSSH and encrypted PEM labels. A second BEGIN marker stops a preceding unmatched block from swallowing unrelated text.labs/chat-export/**to the existingpull_request.pathsfilter.Verification
OPC Labrun #39081604783 completed successfully on commit142b44c(checkverify: success). All steps succeeded, including./scripts/verify.sh(VERIFY_OK template_bytes=2318), OPC fixtures (OPC_TEST_OK), Chat Export fixtures (CHAT_EXPORT_TEST_OK), and the private-pattern scan (OPC_PRIVATE_SCAN_OK).Residual risk
Complete, conventionally delimited PEM blocks are covered; partial/malformed blocks, nonstandard formats, arbitrary secrets, and export metadata are not guaranteed to be redacted. Exported Markdown is private data and must not be uploaded or published.