Repository navigation
Fix the flaky WebSocket tunnel server_list test - #5
Merged
Merged
Conversation
The hub registers a server peer only after it has written the WebSocket handshake response, so a client that dials right after the server can get an initial server_list without it. CI hit this once on main (TestServerWebsocketTunnel_EndToEndAndTenantIsolation saw an empty list). Wait for each server to appear, through a short-lived probe client's server_list or server_online events, before the client under test subscribes. The hot-reload test had the same race and gets the same wait. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failed on main (run 43820507967):
TestServerWebsocketTunnel_EndToEndAndTenantIsolationread an empty initialserver_list.The hub registers a server peer only after writing the WebSocket handshake response, so a client that dials right after the server can subscribe before the server is visible. The test now waits for each server to appear (through a short-lived probe client's
server_list/server_onlineevents) before the client under test subscribes.TestServerWebsocketTunnel_HotReloadRevokesRemovedKeyOnlyhad the same race and gets the same wait.Test-only change. Verified with
go test -race -count=50 -cpu 1,4 -run TestServerWebsocketTunnel ./internal/api/and a fullgo test ./internal/api/.🤖 Generated with Claude Code