Repository navigation
Add tag filtering and custom filters - #862
Closed
priyanshuppal wants to merge 1 commit into
Closed
priyanshuppal wants to merge 1 commit into
priyanshuppal wants to merge 1 commit into
Conversation
Movies and Series can be filtered by a single tag from the filter menu, and by custom filters that work like the Radarr and Sonarr web interface's filters. - Custom filters from the server (/api/v3/customfilter, "movieIndex" and "series") are imported, matched client-side with the web interface's rules, and listed in the filter menu. Filters with conditions Ruddarr can't check are marked and keep those conditions untouched when saved. - Filters can be created and edited with a condition builder, and saved on the device or on the server, where the web interface shows them too. - Active filters show as chips above the grid; each chip clears its filter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
If you want to open a PR that's not 3000 added lines and a minimal implantation of just displaying filters that are read-only from *arr, I'll take a look at it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tag filtering and custom filters to the Movies and Series grids. Custom filters work like the ones in the Radarr and Sonarr web interface.
What's new
/api/v3/customfilter, typemovieIndexfor Radarr andseriesfor Sonarr) together with filters saved on the device.How matching works
CustomFilter.matchesfollows the web interface's client-side rules from the Radarrdevelopand Sonarr v4 frontends:===is strict; string checks ignore case.Keys that need data the app doesn't decode yet are treated as unsupported:
Notes
Models/CustomFilters, the views inViews/Shared/CustomFilters. The Movies and Series views get small additions.Tests/CustomFilterTests.swiftcovers decoding, round-trips, matching rules and dates. The Tests target compiles three model files, added as membership exceptions in the project file.custom-filters.jsonincludes an unsupported filter and a filter of another type, which must be filtered out.String(localized:)/Text, butLocalizable.xcstringsisn't updated yet. Building in Xcode will add them.CHANGELOG.mdandWhatToTesthave entries under Unreleased.Testing
🤖 Generated with Claude Code