Repository navigation
Keep library toolbar buttons together on folded iPhone Duo - #861
Merged
Merged
Conversation
On the folded Duo, iOS moves plain toolbar items into the side rail but keeps items that host their own view in a bar at the top. Since #831 the filter hosts its own icon to keep the theme-colored badge, while sort was still a Label from #819, so the group split: filter on top, sort in the rail. The instance switcher was hidden when folded because the rail had no room for it. Sort and the iPhone instance switcher now use ToolbarIconLabel, the same hosted image with an invisible title as the filter, so all three sit together on top and only + stays in the rail. The switcher shows on the folded Duo again and always uses the navigation placement, so isFolded and hasVerticalToolbar are no longer needed there. The hosted sort image honors .imageScale(.medium), which the native item ignored, so the modifier is dropped to keep the glyph size unchanged.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #859.
On the folded Duo, iOS moves plain toolbar items into the side rail but keeps items that host their own view in a bar at the top. Since #831 the filter hosts its own icon to keep the theme-colored badge, while sort was still a
Labelfrom #819, so the group split: filter on top, sort in the rail. The instance switcher was hidden when folded because the rail had no room for it.Sort and the iPhone instance switcher now use
ToolbarIconLabel, the same hosted image with an invisible title as the filter. All three sit together at the top on Movies and Series, and only + stays in the rail. The switcher shows on the folded Duo again and always uses the navigation placement, soisFoldedandhasVerticalToolbarare no longer needed there. Overflow menus and VoiceOver still get the titles.Putting everything in the rail instead would need the filter to be a
Labelagain, which brings back the red badge dot #831 fixed.Tested on iOS 27.2 simulators with the mock API and two Radarr and two Sonarr instances:
.imageScale(.medium), which the hosted image honors and the native item ignored.Not checked: iPad, where sort now uses the hosted label like the filter already does.
🤖 Generated with Claude Code