Repository navigation
Fix a freeze when opening some movies and series on iPhone - #860
Merged
Merged
Conversation
The details poster stores the measured scroll view width in state and sizes itself at 40% of it. Since the content margins moved onto the scroll view in 2.1.2, that width on a 393pt iPhone settles near 361pt and then alternates between 361.333 and 361.667. Each write moves the poster by a fraction of a point, which shifts a title or overview line break back and forth, so layout never converges and the main thread spins. Ignore width changes under one point. Duo fold changes are hundreds of points, so the poster still resizes there.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #858.
The details poster stores the measured scroll view width in state and sizes itself at 40% of it. Since the content margins moved onto the scroll view in 2.1.2 (#832), that width on a 393pt iPhone settles near 361pt and then alternates between 361.333 and 361.667 forever. Each write moves the poster by a fraction of a point, which shifts a title or overview line break back and forth, so layout never converges and the main thread spins at 100%.
Width changes under one point are now ignored. Duo fold changes are hundreds of points, so the poster still resizes there. Movie details use the same modifier and get the fix too.
Reproduced on the iOS 27.2 simulator (24B114) with the real Sonarr payload for Terminator: The Sarah Connor Chronicles:
🤖 Generated with Claude Code