Add embedded content checks - #121
Conversation
c71eef2 to
381fef6
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f3e680372
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| interval: daily | ||
| time: "10:00" | ||
| timezone: "Europe/Berlin" | ||
| - package-ecosystem: pip |
There was a problem hiding this comment.
🤖 [rubykatzen/baseline]: When a consumer follows the newly documented setup, its Dependabot file contains only the github-actions and pre-commit entries shown in README.md, but enabling the embedder also requires this newly added pip entry and the following bundler entry as part of one exact substring. The resulting embedder workflow therefore fails on the documented configuration unless the consumer skips the entire dependabot fragment; update the example to match the enforced fragment or narrow the fragment to what the setup actually prescribes.
AGENTS.md reference: AGENTS.md:L29-L34
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 890cdb2260
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| The shared workflow checks repository files against the required fragments in | ||
| `config/embedder.yml`. Each named fragment has a target path and content that | ||
| must occur in that file. Multiple fragments may target the same file. Ownership |
There was a problem hiding this comment.
🤖 [rubykatzen/baseline]: A new consumer following this section creates only the workflow, but config/embedder.yml also requires the message-prefix and newly introduced embedded-fragments content in AGENTS.md; if that file or either fragment is absent, the first embedder run fails. Include instructions to install those fragments—or explicitly skip them—so the documented setup produces a passing workflow.
AGENTS.md reference: AGENTS.md:L29-L38
Useful? React with 👍 / 👎.
027fbb5 to
2b55eee
Compare
2b55eee to
2d7c1df
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d7c1dffac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if error: | ||
| diff = fragment_diff(name, fragment.path, fragment.content, "") | ||
| results.append(FragmentResult(name, fragment.path, "failed", error, diff)) | ||
| elif fragment.content not in actual: |
There was a problem hiding this comment.
🤖 [rubykatzen/baseline]: When a consumer commits a target file with CRLF line endings, the configured LF fragment contains the same text but fragment.content not in actual still marks it as failed. Because fragment_diff() then calls splitlines(), the reported diff is empty, so this cross-repository check blocks CI without showing any corrective delta; normalize line endings consistently for matching and diffing.
🪟 📄
AGENTS.md reference: AGENTS.md:L39-L45
Useful? React with 👍 / 👎.
1 participant
🤖 [rubykatzen/baseline]:
Summary
config/embedder.yml: message prefix, agent policy, README notice, and Dependabot configembedder-shared.ymlwith JSONskipsupport and use it in baseline itselfVerification
python3 -m unittest discover -s test -vpre-commit run --all-filesCloses #118