Add explicit GITHUB_TOKEN permissions to workflow caller jobs - #105
Merged
Conversation
CodeQL's actions/missing-workflow-permissions flagged the three reusable-workflow caller jobs that had no effective permissions block (cd.yml, triage.yml, stale.yml). ci.yml and codeql.yml already declare theirs. A caller's permissions become the ceiling for the called workflow, so each grant covers what shared-config actually does: - cd.yml: contents: write — shared-config/cd.yml checks out with persisted credentials and runs discourse/publish-rubygems-action, which does `rake release` (a raw git push of the version tag), then `gh release create`. - triage.yml: issues: write — shared-config/triage.yml runs `gh issue edit --add-label triage`; its own job already declares issues: write. - stale.yml: issues: write + pull-requests: write — actions/stale comments on and closes both stale issues and stale PRs. Style follows the query_packwerk precedent: job-level permissions immediately above `uses:`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL's actions/missing-workflow-permissions flagged the three
reusable-workflow caller jobs that had no effective permissions block
(cd.yml, triage.yml, stale.yml). ci.yml and codeql.yml already declare
theirs. A caller's permissions become the ceiling for the called
workflow, so each grant covers what shared-config actually does:
persisted credentials and runs discourse/publish-rubygems-action,
which does
rake release(a raw git push of the version tag), thengh release create.gh issue edit --add-label triage; its own job already declaresissues: write.
comments on and closes both stale issues and stale PRs.
Style follows the query_packwerk precedent: job-level permissions
immediately above
uses:.Alerts resolved
actions/missing-workflow-permissions(medium) —.github/workflows/cd.yml:11actions/missing-workflow-permissions(medium) —.github/workflows/triage.yml:9actions/missing-workflow-permissions(medium) —.github/workflows/stale.yml:8Verification
permissions:block (cross-checked by parsing the YAML against the alert list).actionlintoutput is byte-identical tomain— no new findings introduced.codeql.ymluntouched.