Add explicit GITHUB_TOKEN permissions to workflows - #37
Merged
Conversation
Resolves the six open `actions/missing-workflow-permissions` CodeQL alerts (#1, #2, #4, #5, #6, #7) by giving every job an explicit, least-privilege permissions block. - ci.yml: one workflow-level `contents: read`. All three jobs (rspec, static_type_check, notify_on_failure) only check out the repo and run rspec / srb tc; the Slack notifier posts to an incoming webhook and needs no GitHub API scope at all, so read is the floor that covers the file. - cd.yml: `contents: write` on the caller job. shared-config's cd.yml runs discourse/publish-rubygems-action, which does a raw `git push` of the release tag, and then `gh release create` — both need write. Caller permissions are the ceiling for a reusable workflow, so anything less would break releases. - stale.yml: `issues: write` + `pull-requests: write`. shared-config's stale.yml runs actions/stale, which comments on and closes both stale issues and stale PRs. - triage.yml: `issues: write`. shared-config's triage.yml runs `gh issue edit --add-label triage` (its own job already declares `issues: write`; the caller must grant at least that). codeql.yml already declares its permissions and is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the six open
actions/missing-workflow-permissionsCodeQL alerts(#1, #2, #4, #5, #6, #7) by giving every job an explicit, least-privilege
permissions block.
contents: read. All three jobs (rspec,static_type_check, notify_on_failure) only check out the repo and run
rspec / srb tc; the Slack notifier posts to an incoming webhook and needs
no GitHub API scope at all, so read is the floor that covers the file.
contents: writeon the caller job. shared-config's cd.yml runsdiscourse/publish-rubygems-action, which does a raw
git pushof therelease tag, and then
gh release create— both need write. Callerpermissions are the ceiling for a reusable workflow, so anything less
would break releases.
issues: write+pull-requests: write. shared-config'sstale.yml runs actions/stale, which comments on and closes both stale
issues and stale PRs.
issues: write. shared-config's triage.yml runsgh issue edit --add-label triage(its own job already declaresissues: write; the caller must grant at least that).codeql.yml already declares its permissions and is untouched.
Alerts resolved
actions/missing-workflow-permissions(medium) —.github/workflows/ci.yml:42actions/missing-workflow-permissions(medium) —.github/workflows/ci.yml:30actions/missing-workflow-permissions(medium) —.github/workflows/ci.yml:11actions/missing-workflow-permissions(medium) —.github/workflows/triage.yml:9actions/missing-workflow-permissions(medium) —.github/workflows/stale.yml:8actions/missing-workflow-permissions(medium) —.github/workflows/cd.yml:11Verification
permissions:block (cross-checked by parsing the YAML against the alert list).actionlintoutput is byte-identical tomain— no new findings introduced.codeql.ymluntouched.