Skip to content

faraday: Add Connection#build_url method signature#1002

Open
ssshhhooota wants to merge 1 commit intoruby:mainfrom
ssshhhooota:add-faraday_build_url
Open

faraday: Add Connection#build_url method signature#1002
ssshhhooota wants to merge 1 commit intoruby:mainfrom
ssshhhooota:add-faraday_build_url

Conversation

@ssshhhooota
Copy link

Add type definition for Faraday::Connection#build_url method.

The Faraday::Connection#build_url method builds a complete URI by combining the connection's URL prefix with a relative path and optional query parameters.

References:

https://github.com/lostisland/faraday/blob/c6988a840738760fae1a40d653fa2ccd0da425b9/lib/faraday/connection.rb#L415
https://www.rubydoc.info/gems/faraday/Faraday/Connection#build_url-instance_method

This is my first PR to this repository, so I'd appreciate a review if possible.

@github-actions
Copy link

@ssshhhooota Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

faraday

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@yykamei, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant