Repository navigation
deps: audit with mix hex.audit, bump mint and lazy_html - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the dependency audit from
mix_audittomix hex.audit, and bumpsmintandlazy_htmlto clear the four advisories it reports.Before:
security.ymlandtask security:depsranmix deps.audit(mix_audit 2.1.5).Problem
After: both run
mix hex.audit, which reports advisories and retired packages. Themix_auditdependency is gone, withyaml_elixirandyamerl, which only it used. The audit is clean.No waivers.
Details
mix hex.audit. Both workflows runmix local.hex --force, which installs the latest Hex.cloaked_reqwreq adapter, so Mint only comes in through Req and Finch and is not on our request path.to_html/2and addsLazyHTML.css_path/1. We only callfrom_document,query,text, andattribute.MIX_ENV=test mix compile --warnings-as-errors,MIX_ENV=test mix test(54 passed, 3 live tests excluded), andmix hex.audit("No retired or security advisory packages found").