Repository navigation
deps: audit with mix hex.audit and bump mint to 1.11.0 - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #76, which lets CI run on pull requests that the agent opens. Only the commits after it are new here.
Switches the dependency audit from
mix deps.audit(mix_audit) tomix hex.auditand bumpsmintto 1.11.0.Before:
task security:deps,ci.yml, andsecurity.ymlrunMIX_ENV=test mix deps.audit. mix_audit 2.1.5 reads only a GitHub advisory mirror and does not see the Hex advisory feed (EEF CNA).mint1.10.1 has three advisories that it did not report.Problem
mint1.10.1 (throughreqandfinch) has one HIGH and two MEDIUM advisories.After: all three places run
MIX_ENV=test mix hex.audit. Themix_auditdependency is gone, withyaml_elixirandyamerl, which only it pulled in. The audit ends with "No retired or security advisory packages found". No waivers.mint1.10.1mint1.11.0mint1.10.1mint1.11.0mint1.10.1mint1.11.0Details
mint1.11.0 needshpax ~> 1.1, sohpaxgoes from 1.0.4 to 1.1.0. Themint1.11.0 changelog says "no breaking changes"; the other entries are stricter HTTP/1 and HTTP/2 parsing. Thehpax1.1.0 changelog addsHPAX.protocol_resize/2and returns errors instead of raising.cloaked_reqdoes not call Mint or HPAX; only Req's default Finch adapter uses them. No code change.mix hex.audit. Both workflows runmix local.hex --force, which installs the newest Hex (2.5.1 today, perbuilds.hex.pm/installs/hex-1.x.csv).mix deps.auditis history and stays. The changelog has no Unreleased section.mix hex.auditprototype of the shared security workflow (stub project with the hexpm lock): clean.MIX_ENV=test mix compile --warnings-as-errors: clean.MIX_ENV=test mix test: 96 passed, 3 excluded.