refactor: replace external hook scripts with native 'rtk hook claude' command

[romansl]

BREAKING CHANGE: External hook scripts (hooks/rtk-rewrite.sh) are no longer installed or used. Existing hook files can be safely deleted.

• Add native 'rtk hook claude' command that reads/writes JSON directly
• Remove hooks/rtk-rewrite.sh embedded script (no longer needed)
• Update init.rs: install hook via 'rtk hook claude' instead of script files
• Update hook_check.rs: native hook is always available (no file checks)
• Remove dead code: prepare_hook_paths(), ensure_hook_installed()
• Add cross-platform support (works identically on Windows, macOS, Linux)

Benefits:

• No external dependencies (bash, jq)
• Faster: no fork/exec subprocess overhead
• Simpler installation: just 'rtk init -g', no script files

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

[CLAassistant]

All committers have signed the CLA.

[pszymkowiak]

[w] wshm · Automated triage by AI

📊 Automated PR Analysis

♻️ Type	refactor
🟡 Risk	medium

Summary

Replaces the external bash hook script (hooks/rtk-rewrite.sh) with a native 'rtk hook claude' command built into the Rust binary. This eliminates dependencies on bash and jq, removes file-based hook installation/version checking, and simplifies the setup to just 'rtk init -g' across all platforms.

Review Checklist

• Tests present
• Breaking change
• Docs updated

---

Analyzed automatically by wshm · This is an automated analysis, not a human review.

[pszymkowiak]

Thanks @romansl — this is the right long-term direction. Eliminating bash + jq saves ~5-10ms per hook call, which adds up over a full session.

However, the PR has 3 blocking issues and a scope concern:

P0 — Security regression

1. Permission deny/ask rules dropped — run_claude() calls rewrite_command() but never check_command() from src/permissions.rs. Every command that should be denied or prompted is silently auto-allowed. This is a security regression shipped in PR #576.

2. Audit logging dropped — RTK_HOOK_AUDIT=1 writes to ~/.local/share/rtk/hook-audit.log are gone. Users relying on rtk hook-audit get an empty log after upgrading.

3. Migration breaks existing installs — hook_already_present no longer matches rtk-rewrite.sh in settings.json. Running rtk init -g after upgrade inserts a duplicate hook entry instead of replacing the old one.

P1 — Missing wiring

4. rtk hook claude subcommand doesn't exist in HookCommands enum — clap returns "unrecognized subcommand"
5. hook_check::status() always returns OK — rtk gain loses the "run rtk init" diagnostic

Scope concern — should cover all agents, not just Claude Code

RTK supports 10 AI tools (Claude, Gemini, Copilot, Cursor, Windsurf, Cline, Codex, OpenCode, OpenClaw, Vibe). This PR only makes the hook native for Claude Code. If we go native for one, we should plan the same for Gemini (rtk hook gemini) and Copilot (rtk hook copilot) to avoid maintaining two architectures (bash hooks + native hooks) indefinitely.

We'd prefer a unified design:

• rtk hook claude (this PR, once fixed)
• rtk hook gemini (already exists, needs same native treatment)
• rtk hook copilot (already exists, needs same native treatment)
• All sharing the same permission check + audit log + 4-exit-code protocol

Next steps: we need to think about how to architect this properly across all agents. Are there other PRs or designs you're aware of that tackle this? We'd like to avoid fragmented efforts. Let us know if you'd like to collaborate on a broader design before reworking — we can open a design issue to align.

We'll assign @aeppling for architectural review as well. Thanks for the solid foundation!

[aeppling]

Hey

We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes src/ from a flat layout into subfolders.

No logic changes — only file moves and import path updates.

What you need to do

Rebase your branch on develop when receiving this comment:

git fetch origin && git rebase origin/develop

Git detects renames automatically. If you get import conflicts, update the paths:

use crate::git;        // now: use crate::cmds::git::git;
use crate::tracking;   // now: use crate::core::tracking;
use crate::config;     // now: use crate::core::config;
use crate::init;       // now: use crate::hooks::init;
use crate::gain;       // now: use crate::analytics::gain;

Need help rebasing? Tag @aeppling

[romansl]

I asked Claude to fix all the comments (each fix in a separate commit).

0. rebase to dev
1. fixed
2. fixed
3. fixed
4. Claude didn't find any issues
5. fixed

Unfortunately, I was only able to do this for Claude Code and I don't know how this will work for other agents.

[aeppling]

PR #862 (by @FlorianBruniaux) implements the same goal — replacing external hook scripts with a native rtk hook claude command, and is actively maintained, MERGEABLE, and further along in review.

Thank you @romansl for the significant effort, the architectural direction you proposed is essentially what #862 is delivering.