Repository navigation
fix(ci): stop setup-node 7 caching in steps that install no dependencies - #62
Open
aryanjasala wants to merge 1 commit into
Open
aryanjasala wants to merge 1 commit into
aryanjasala wants to merge 1 commit into
Conversation
setup-node 5 and later start caching on their own when package.json names a packageManager, and fail when that lockfile is missing. The three setup-node steps that install no project dependencies (ci-detect-changes, version-monitor, ci-test-build-artifact) now set package-manager-cache: false, ahead of the setup-node 7 bump (#54).
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
3 open issues
What changed in this PR
Prepares GitHub Actions workflows for actions/setup-node v7 by explicitly opting out of automatic package-manager caching in steps that don’t install project dependencies, avoiding failures when a lockfile is absent.
Changes:
- Add
package-manager-cache: falsetoactions/setup-nodesteps that install no project dependencies. - Document why caching is disabled (auto-caching behavior + missing lockfile failure mode).
| File | Description |
|---|---|
| .github/workflows/version-monitor.yml | Disables setup-node auto caching for a non-dependency-installing step. |
| .github/workflows/ci-test-build-artifact.yml | Disables setup-node auto caching for a non-dependency-installing step. |
| .github/workflows/ci-detect-changes.yml | Disables setup-node auto caching for a non-dependency-installing step. |
Review effort: Lite
This was referenced Nov 5, 2026
Adi-ty
approved these changes
Nov 10, 2026
Collaborator
|
I'm confused by the premise - why do we want to opt-out of package caching? Isn't that like half the reason we use setup-node instead of rolling our own? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this PR does
Gets ready for setup-node 7 (Dependabot #54). setup-node 5 and later start caching on their own when
package.jsonnames apackageManager, and fail when that lockfile is missing. The three setup-node steps that install no project dependencies now opt out.Closes
N/A
Changes
ci-detect-changes.yml,version-monitor.yml,ci-test-build-artifact.yml:package-manager-cache: falseon the setup-node step. The other setup-node steps already setcache: npmwith an explicitcache-dependency-path.How I verified
Reviewer notes
main, the new input only produces an "Unexpected input" warning, so merging first is harmless but noisy.@v1callers never get setup-node 7 without this.