Repository navigation
fix(ci): let the caller choose the runner, default to GitHub-hosted - #42
Merged
Merged
Conversation
#37 hard-coded runs-on: [self-hosted] in every job. A reusable workflow's jobs run in the calling repository, so public callers (theme-elementary, plugin-elementary, outside users) and this now-public repository's own CI wait for a runner that never comes, while rtCamp's private repositories are required by org policy to use self-hosted runners. Every reusable workflow now takes a runs-on input (JSON, default "ubuntu-latest"), and wp-ci.yml and wp-cd.yml forward it to every workflow they call. ci-self-check.yml runs on ubuntu-latest. bin/check-workflows.sh requires reusable workflows to use and forward the input instead of checking a label allow-list, and keeps the allow-list (ubuntu-latest) for this repo's own CI.
AnuragVasanwala
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#37 (rtBot) hard-coded
runs-on: [self-hosted]in every job, per the org policy for private repositories. A reusable workflow's jobs run in the calling repository, so:ci-self-check.yml) waits for a self-hosted runner that never picks it up (see chore: merge release/v1.0.0 into main (merge commit only) #41);Hard-coding either label is wrong for one of them, so the caller chooses.
Changes
Every reusable workflow gains a
runs-oninput (JSON: a label or a list of labels), default"ubuntu-latest", and every job usesruns-on: ${{ fromJSON(inputs.runs-on) }}.wp-ci.ymlandwp-cd.ymlforward it to all 13 workflows they call (runs-on: ${{ inputs.runs-on }}).ci-self-check.yml(this repo's own CI) runs onubuntu-latest.bin/check-workflows.shnow requires reusable workflows to declare the input, use it on every job, and forward it to every leaf. This repo's own CI is checked against an allow-list (ubuntu-latest).README, AGENTS.md and CHANGELOG describe the input. rtCamp private repos pass:
The #38 additions for the self-hosted image (pinned
yq, the AWS CLI install when missing) stay; they are no-ops where the tools exist.Decision to check
The default is GitHub-hosted, because the repository is public and its examples are meant to run as-is. The alternative is defaulting to
'["self-hosted"]', so private rtCamp repos comply without passing anything, at the cost of every public caller having to override it. Today private callers such as icimod already run these workflows on GitHub-hosted runners through@release/v1.0.0.Testing
bin/check-workflows.sh,actionlintandyamllint -c .yamllint.yml .passbin/check-workflows.shfails, as intended, when a reusable workflow hard-codes a label, when an orchestrator leaf does not forwardruns-on, and whenci-self-check.ymlgoes back to[self-hosted]ubuntu-latest