Repository navigation
fix(deps): require patched Node for CVE-2026-111497 - #820
Merged
Merged
Conversation
Node.js 22.23.4, 24.22.1 and 26.12.1 fix CVE-2026-111497, a high-severity out-of-bounds write in the Brotli decoder. Raise .nvmrc (which the shared CI workflows read) and the engines floor so earlier, affected releases warn on install. Ref: https://nodejs.org/en/blog/vulnerability/october-2026-security-releases
There was a problem hiding this comment.
🟡 Changes recommended
npm engine requirements remain advisory, so normal installations can still proceed on runtimes below the patched-version floors.
1 open issue
What changed in this PR
Updates the theme’s Node.js requirements to target patched releases for CVE-2026-111497.
Changes:
- Raises the
.nvmrcversion to 22.23.4. - Updates the supported Node.js ranges in the package manifest and lockfile.
- Aligns the getting-started documentation with the new Node 22 minimum.
| File | Description |
|---|---|
package.json |
Raises the declared Node.js engine requirements. |
package-lock.json |
Synchronizes the root package’s engine requirements. |
docs/getting-started.md |
Updates the documented Node.js minimum. |
.nvmrc |
Pins Node.js to 22.23.4. |
Review effort: Balanced
npm treats engines as advisory, so an affected Node only got an EBADENGINE warning. engine-strict makes npm ci / npm i (including Composer's npm i hook) fail instead. Patched 22.23.4 and 24.22.1 still install cleanly.
engine-strict turned the engines floor into a hard install failure. Node here only runs dev tooling (build, lint, tests, wp-env), so CVE-2026-111497 exposure is minimal, and the security ask is the .nvmrc and engines bump, not enforcement. engine-strict also failed CI, since the shared wp-ci@v1 installs the runner-cached Node 22.23.3 instead of reading .nvmrc (rtCamp/wp-shared-workflows#47). Affected releases still get an npm EBADENGINE warning. This reverts commit 3abb8f4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"22.23.4 or later" read as if any newer Node were fine, but 24.21.0 is newer and still affected, and engines rejects it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aryanjasala
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Raises
.nvmrcto 22.23.4 and theenginesfloor to^22.23.4 || ^24.22.1 || >=26.12.1, so installing on a Node release affected by CVE-2026-111497 (high, Brotli decoder OOB write) shows an npmEBADENGINEwarning. The getting-started docs now name each patched line.enginesstays advisory on purpose. Node only runs dev tooling here (build, lint, tests,wp-env), never in production, so the exposure is minimal. Anengine-strictcommit was added and then reverted: it made installs fail on affected Node, which also broke CI. The sharedwp-ci.yml@v1doesn't read.nvmrcyet and installs the runner's cached Node 22.23.3. rtCamp/wp-shared-workflows#47 fixes that, and once it's merged andv1is moved, CI here runs on 22.23.4.Ref: https://nodejs.org/en/blog/vulnerability/october-2026-security-releases
Fixes/Covers issue
N/A