Skip to content

fix: encode multifile hash as utf8 - #360

Merged
dbkegley merged 2 commits into
mainfrom
fix-multi-file-upload
Oct 1, 2026
Merged

dbkegley merged 2 commits into
mainfrom
fix-multi-file-upload

Conversation

@dbkegley

@dbkegley dbkegley commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #359.

Version.from_files() now encodes the combined hash string as UTF-8 before it calls xxh64(). Existing version hashes do not change. A new test covers multi-file pins.

@dbkegley
dbkegley merged commit 581639c into main Oct 1, 2026
14 of 15 checks passed
@dbkegley
dbkegley deleted the fix-multi-file-upload branch October 1, 2026 19:05

This branch was successfully deployed

1 active deployment
pr-360 — 9b0caa69 Deployed Oct 1, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pin_upload() with multiple files fails on xxhash 4.x: TypeError: Strings must be encoded before hashing

2 participants