-
Notifications
You must be signed in to change notification settings - Fork 10
feat: add when condition to ExtraTool for template-based filtering
#96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add when condition to ExtraTool for template-based filtering
#96
Conversation
Summary of ChangesHello @Timeless0911, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the 'ExtraTool' functionality by adding a 'when' condition, enabling developers to specify when a particular tool should be available or applied. This improvement allows for more intelligent and context-specific tool management, preventing irrelevant tools from appearing or being used with certain project templates. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
when condition to ExtraTool for template-based filtering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a when condition to ExtraTool for conditionally enabling tools based on the selected template, which is a great enhancement for modularity. The implementation is solid, with corresponding additions to the ExtraTool type and filtering logic in getTools. The new functionality is also well-covered by a new test case. I have one minor suggestion to improve the readability of the filtering logic.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
chenjiahan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR introduces a
whenproperty to theExtraTooltype. This allows developers to define a condition (based on the selected template name) that determines whether a tool should be displayed in the selection list or applied when specified via CLI options.Changes
whenoptional property toExtraTooltype.getToolsto filterextraToolsbased on thewhencondition and the currenttemplateName.Motivation
Sometimes certain tools are only relevant for specific templates (e.g., a Vue-specific tool shouldn't show up for a React template). This change provides a clean way to handle such scenarios.