Skip to content

Conversation

@Timeless0911
Copy link
Member

Description

This PR introduces a when property to the ExtraTool type. This allows developers to define a condition (based on the selected template name) that determines whether a tool should be displayed in the selection list or applied when specified via CLI options.

Changes

  • src/index.ts:
    • Added when optional property to ExtraTool type.
    • Updated getTools to filter extraTools based on the when condition and the current templateName.
  • test/custom-tools.test.ts:
    • Added a new test case "should filter extra tools based on template name" to verify the filtering logic.

Motivation

Sometimes certain tools are only relevant for specific templates (e.g., a Vue-specific tool shouldn't show up for a React template). This change provides a clean way to handle such scenarios.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Timeless0911, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the 'ExtraTool' functionality by adding a 'when' condition, enabling developers to specify when a particular tool should be available or applied. This improvement allows for more intelligent and context-specific tool management, preventing irrelevant tools from appearing or being used with certain project templates.

Highlights

  • Conditional Tool Display: Introduced a 'when' property to the 'ExtraTool' type, allowing tools to be conditionally displayed or applied based on the selected template name.
  • getTools Logic Update: The 'getTools' function now filters 'extraTools' using the new 'when' condition, ensuring only relevant tools are processed.
  • New Test Case: A dedicated test case was added to 'test/custom-tools.test.ts' to validate the 'extraTools' filtering logic based on the template name.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Timeless0911 Timeless0911 changed the title feat: add 'when' condition to ExtraTool for template-based filtering feat: add when condition to ExtraTool for template-based filtering Jan 29, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a when condition to ExtraTool for conditionally enabling tools based on the selected template, which is a great enhancement for modularity. The implementation is solid, with corresponding additions to the ExtraTool type and filtering logic in getTools. The new functionality is also well-covered by a new test case. I have one minor suggestion to improve the readability of the filtering logic.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenjiahan chenjiahan merged commit 5a07725 into rstackjs:main Jan 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants