Skip to content

feat(plan,verify): checkable Given/When/Then criteria, traced from the spec (#69) - #121

Merged
rshankras merged 1 commit into
mainfrom
feat/69-acceptance-criteria
Nov 6, 2026
Merged

rshankras merged 1 commit into
mainfrom
feat/69-acceptance-criteria

Conversation

@rshankras

Copy link
Copy Markdown
Owner

Closes #69.

In plain words

Today a task is "done" when a loose line like "Profile screen works" is ticked, and verify only checks the plan, so anything the plan forgot is never checked. Now each task says exactly what must be true (Given … When … Then …) and what proves it, and verify first writes its own list from the spec, so a forgotten feature shows up as a gap.

What changed

  • plan: new "Acceptance Criteria" section.
    • Lists the features this phase promises (APP.md for new apps, RELEASE.md ids for updates; bugs use their symptom).
    • Asks about vague features before writing tasks (up to 4 per question); answers go in <spec-clarifications>. Under autonomous it never asks: it records the safest reading as source="assumed".
    • Each criterion: via="screen" (what's on screen) or via="package" (a Swift package's public functions), and a <proof>: test / flow / lint / manual.
    • Completion message shows how many promised features have criteria.
  • verify: Step 1 writes its own list from the spec without opening PLAN.md; Step 2 compares and traces feature → criterion → proof. A must-feature with no criterion fails; missing proofs and missed cases are partial. Older plans with no criteria still verify, against <done>.
  • VERIFICATION.md: new Spec Coverage table and summary line.
  • build: agents write the tests the criteria name, testing from outside.
  • autonomous: the independent verifier gets the spec first; assumptions show in the phase recap.
  • PLAN.md template, CLAUDE.md, CHANGELOG.

Test

./scripts/validate.sh passes. Behavior needs a real project run (next /apple:plan + /apple:verify).

🤖 Generated with Claude Code

…e spec (#69)

plan writes acceptance criteria per task with a named proof, asks about
vague spec items before the build, and records answers. verify writes its
own list from APP.md/RELEASE.md before reading PLAN.md, then traces every
promised feature to a criterion and proof; untraced promises are issues.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rshankras
rshankras merged commit 146cff2 into main Nov 6, 2026
2 checks passed
@rshankras
rshankras deleted the feat/69-acceptance-criteria branch November 6, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(plan,verify): acceptance criteria as testable Given/When/Then, derived from the spec

1 participant