Repository navigation
feat(plan,build): enforce design-system rules on every UI task - #107
Merged
Merged
Conversation
- 'has a design system' = DESIGN-SYSTEM.md or ds_* rules in .swiftlint.yml - plan: view tasks get type=lint + new type=design check (state previews per platform, identifiers, <300 lines, new files never baselined), design/design-system in apple-patterns, components named in action - build: routing row -> swiftui-builder + design/design-system; <design-system> block + requirement 6 for UI spawns; design check type - design lint gate after every view-touching task: whole-tree lint with baseline filtered to touched files (path args break baseline matching); baseline may only shrink - no design system: unchanged Closes #99 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99
Why
#92 taught
swiftui-builderthe design-system rules, but nothing checked them per task. A task could produce raw styling and still pass, and the problem only surfaced at review (#93) or phase-end verify (#98), by which point it had spread across the phase.What
A project has a design system when
.planning/DESIGN-SYSTEM.mdexists (from #95) or.swiftlint.ymlcontains theds_*rules. Without one, nothing changes./apple:planreads DESIGN-SYSTEM.md. Every view-touching task then:type="lint"(the design rules plus the baseline)type="design"check, covering the per-task subset of the verify: per-screen design-system definition of done for UI phases #98 definition of done:design/design-systemin<apple-patterns>and names the components to use in<action>/apple:build:swiftui-builderwithdesign/design-system+design/typography.<design-system>block (token map, text styles, components) and requirement 6: tokens and.appTextonly, listed components,ContentStateView, identifiers, under ~300 lines, missing tokens added to the token file rather than inlined.design, run by the orchestrator, not taken from the agent's report.<verify>omits it, as with the always-on build check. New code must have zero violations, and the baseline may only shrink: rewriting it to absorb new violations is a FAIL.Bug caught while testing the gate
swiftlint lint --baseline X <file paths>does not match the passed files against the baseline. The stored paths differ, so baselined legacy violations showed up as new: a touched legacy file would always fail. The gate now lints the whole tree with the baseline and filters the output to the touched files. I checked it on a fixture:Checks
./scripts/validate.sh: all pass.🤖 Generated with Claude Code