Skip to content

docs(NewWithTime): note 4-byte timestamp can't hold post-2106 times #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c-tonneslan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs(NewWithTime): note 4-byte timestamp can't hold post-2106 times #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion id.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,13 @@ func New() ID {
return NewWithTime(time.Now())
}

// NewWithTime generates a globally unique ID with the passed in time
// NewWithTime generates a globally unique ID with the passed in time.
//
// The XID format stores the timestamp in 4 bytes, so it can only represent
// times whose Unix seconds fit in a uint32. Times before 1970-01-01 or
// after 2106-02-07 06:28:15 UTC silently wrap when encoded; callers
// generating IDs from arbitrary user-supplied times should clamp or
// reject those values themselves.
func NewWithTime(t time.Time) ID {
var id ID
// Timestamp, 4 bytes, big endian
Expand Down