Skip to content

combine_distance_matrices.py fails on numpy 1.12, requires 1.14 #10

Description

@maxlcummins

combine_distance_matrices.py script does not work with numpy version 1.12 - I had to updated to 1.14 and then it worked for me.

Might be worth flagging this in the README. Not sure about other versions of numpy (1.13 might work based on my research but I didn't test this). The issue is with line 115:

slope, intercept = np.linalg.lstsq(a, y, rcond=None)[0]

For some reason it fails with earlier versions of numpy and throws the following error:

Traceback (most recent call last):
  File "../scripts/combine_distance_matrices.py", line 190, in <module>
    main()
  File "../scripts/combine_distance_matrices.py", line 43, in main
    args.matrix_1, args.matrix_2)
  File "../scripts/combine_distance_matrices.py", line 116, in distance_regression
    slope, intercept = np.linalg.lstsq(a, y, rcond=None)[0]
  File "/home/malcummi/Data/miniconda3/envs/bacsort_fastani/lib/python3.6/site-packages/numpy/linalg/linalg.py", line 1961, in lstsq
    0, work, -1, iwork, 0)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions