Conversation
NewWatcher reconciles an external credential catalog into the conductor without replacing live token metadata. Embedders can adopt it instead of copying the add, update, and shadow-removal loop. Deletion of that copy waits until the module pin moves.
|
This pull request targeted The base branch has been automatically changed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Export
sdk/cliproxy/authsource.NewWatcher, a public constructor for the catalog auth-source reconcile.Synclists aSource, then:pc-cred-*authspc_token_rotated_atchangedbase_url*coreauth.ManagersatisfiesTarget. The file watcher underinternal/watcheris unchanged.Why
internal/watcheris not importable by other modules, and file/config synthesis is the wrong source for a database catalog. Embedders currently copy this add/update/shadow loop. This export unlocks deleting that copy.The proxy deletion waits until the module pin moves. This pull request does not change proxy behavior by itself.
Tests
go test ./sdk/cliproxy/authsource/