-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
fix(claude): restore max_tokens=1 probe short-circuit compatibility #3571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lyzgeorge
wants to merge
18
commits into
router-for-me:dev
Choose a base branch
from
lyzgeorge:main
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
527f769
Handle Claude max_tokens one probes
1d2f224
feat(codex): enable buffered failover defaults
085596b
fix(codex): preserve native client identity
b4cdcad
fix(codex): prefer native user agent over defaults
cdd4f53
Merge remote-tracking branch 'origin/main' into fix/codex-client-fide…
386ba4a
Merge branch 'router-for-me:main' into main
lyzgeorge db9925e
Merge remote-tracking branch 'origin/main'
e13a4a4
Merge latest upstream preserving max_tokens probes and Codex client f…
269d592
Merge branch 'router-for-me:main' into main
lyzgeorge b24ab15
Merge upstream v7.3.19, preserve local probes and Codex identity
00aafbe
Merge upstream v8.0.3, preserve local token probe and Codex identity
b3abf60
feat(registry): expose Claude Sonnet 5.5
92f552c
Revert "feat(registry): expose Claude Sonnet 5.5"
c8d7892
feat(registry): keep Claude Sonnet 5.5 through remote refresh
dbfc199
Revert Claude Sonnet 5.5 registry override
2adc36f
Merge latest upstream while preserving local Codex identity and max t…
2e950d9
Merge upstream v8.0.13 while preserving local Codex identity and max …
b9092d1
Merge remote-tracking branch 'origin/main'
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a Codex SSE upstream emits an initial bufferable event such as
response.createdand then sends no further complete line, enabling buffering by default with a 30-second timeout can leave downstream headers uncommitted indefinitely. The timeout incodex_executor_stream.gois checked only afterscanner.Scan()returns another line, so it cannot release the already buffered event while the scan is blocked; native Responses clients that previously receivedresponse.createdimmediately can therefore hit reverse-proxy/client read timeouts despite this configured ceiling. Use an asynchronous release mechanism or keep buffering opt-in for this path.Useful? React with 👍 / 👎.