feat(exgentic-runner): allow NAMESPACE override via env var#35
Merged
Conversation
The deploy and evaluate scripts hardcode 'team1' as the target namespace,
which blocks side-by-side testing in a second namespace (e.g. team2) to
avoid clobbering existing workloads.
Make the three anchor sites honor ${NAMESPACE:-team1} so 'team1' remains
the default but the env var wins when set:
deploy-agent.sh:194 NAMESPACE="team1" default
deploy-benchmark.sh:126 NAMESPACE="team1" default
evaluate-benchmark.sh:175 tool_http_url ... "team1"
evaluate-benchmark.sh:177 agent_http_url ... "team1"
evaluate-benchmark.sh:390 INFRA_NAMESPACE="team1"
No behavior change unless NAMESPACE is set in the caller's env.
Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
yoavkatz
approved these changes
Jul 21, 2026
Contributor
|
I merged the changes. I think adding --namespace argument makes sense. |
yoavkatz
added a commit
to yoavkatz/workload-harness
that referenced
this pull request
Jul 21, 2026
…ride
Resolve conflicts in deploy-agent.sh and deploy-benchmark.sh by combining
the experiment-suffix block from this branch with NAMESPACE="${NAMESPACE:-team1}"
from rossoctl/main (PR rossoctl#35), so both features coexist.
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-agent.sh,deploy-benchmark.sh, andevaluate-benchmark.shhardcode"team1"as the target namespace in five places. This blocks running a benchmark in a second namespace (e.g.team2) to keep it isolated from existing workloads.Make those sites honor
${NAMESPACE:-team1}—team1remains the default, but callers can override:No behavior change unless
NAMESPACEis set in the caller's env.Motivation
I hit this while testing PR #33 on an OpenShift cluster that already had prior benchmark workloads running in
team1. Deploying on top would have either collided or forced me to tear down other people's work.team2was empty and would have been the natural target, but I had to patch the scripts to get there.The change
5 lines total:
Test plan
NAMESPACE=team2 OPENAI_API_BASE=... ./deploy-and-evaluate.sh --benchmark gsm8k --agent tool_calling --openshift apps.ykt3.hcp.res.ibm.com --experiment pr33-ocp-local— all three phases deployed and evaluated cleanly againstteam2on OpenShift (15/15 sessions, 93.3% eval success).NAMESPACE=team2 OPENAI_API_BASE=... ./deploy-and-evaluate.sh --benchmark tau2 ...— same, 15/15 sessions, 73.3% success.NAMESPACE: all Phase A runs on kind usedteam1as before.Alternatives considered
--namespace <ns>CLI flag would be more discoverable, but requires argparse changes in each of the three scripts and their wrapper (deploy-and-evaluate.sh). This env-var route is smaller and matches existing patterns in the codebase (OPENAI_API_KEY,HF_TOKEN,EXGENTIC_REGISTRY,IMAGE_TAGare all env-only). Happy to add the CLI flag as a follow-up if preferred.Assisted-By: Claude Code