Skip to content

feat(exgentic-runner): allow NAMESPACE override via env var#35

Merged
yoavkatz merged 1 commit into
rossoctl:mainfrom
kellyaa:feat/namespace-override
Jul 21, 2026
Merged

feat(exgentic-runner): allow NAMESPACE override via env var#35
yoavkatz merged 1 commit into
rossoctl:mainfrom
kellyaa:feat/namespace-override

Conversation

@kellyaa

@kellyaa kellyaa commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

deploy-agent.sh, deploy-benchmark.sh, and evaluate-benchmark.sh hardcode "team1" as the target namespace in five places. This blocks running a benchmark in a second namespace (e.g. team2) to keep it isolated from existing workloads.

Make those sites honor ${NAMESPACE:-team1}team1 remains the default, but callers can override:

NAMESPACE=team2 ./deploy-and-evaluate.sh --benchmark gsm8k --agent tool_calling --openshift apps.mycluster.example.com

No behavior change unless NAMESPACE is set in the caller's env.

Motivation

I hit this while testing PR #33 on an OpenShift cluster that already had prior benchmark workloads running in team1. Deploying on top would have either collided or forced me to tear down other people's work. team2 was empty and would have been the natural target, but I had to patch the scripts to get there.

The change

5 lines total:

deploy-agent.sh:194         NAMESPACE="team1"                        → "${NAMESPACE:-team1}"
deploy-benchmark.sh:126     NAMESPACE="team1"                        → "${NAMESPACE:-team1}"
evaluate-benchmark.sh:175   tool_http_url  ... "team1"               → "${NAMESPACE:-team1}"
evaluate-benchmark.sh:177   agent_http_url ... "team1"               → "${NAMESPACE:-team1}"
evaluate-benchmark.sh:390   export INFRA_NAMESPACE="team1"           → "${NAMESPACE:-team1}"

Test plan

  • Ran NAMESPACE=team2 OPENAI_API_BASE=... ./deploy-and-evaluate.sh --benchmark gsm8k --agent tool_calling --openshift apps.ykt3.hcp.res.ibm.com --experiment pr33-ocp-local — all three phases deployed and evaluated cleanly against team2 on OpenShift (15/15 sessions, 93.3% eval success).
  • Ran NAMESPACE=team2 OPENAI_API_BASE=... ./deploy-and-evaluate.sh --benchmark tau2 ... — same, 15/15 sessions, 73.3% success.
  • Verified default behavior unchanged by not setting NAMESPACE: all Phase A runs on kind used team1 as before.

Alternatives considered

  • A --namespace <ns> CLI flag would be more discoverable, but requires argparse changes in each of the three scripts and their wrapper (deploy-and-evaluate.sh). This env-var route is smaller and matches existing patterns in the codebase (OPENAI_API_KEY, HF_TOKEN, EXGENTIC_REGISTRY, IMAGE_TAG are all env-only). Happy to add the CLI flag as a follow-up if preferred.

Assisted-By: Claude Code

The deploy and evaluate scripts hardcode 'team1' as the target namespace,
which blocks side-by-side testing in a second namespace (e.g. team2) to
avoid clobbering existing workloads.

Make the three anchor sites honor ${NAMESPACE:-team1} so 'team1' remains
the default but the env var wins when set:

  deploy-agent.sh:194        NAMESPACE="team1" default
  deploy-benchmark.sh:126    NAMESPACE="team1" default
  evaluate-benchmark.sh:175  tool_http_url ... "team1"
  evaluate-benchmark.sh:177  agent_http_url ... "team1"
  evaluate-benchmark.sh:390  INFRA_NAMESPACE="team1"

No behavior change unless NAMESPACE is set in the caller's env.

Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
@kellyaa
kellyaa requested a review from yoavkatz July 20, 2026 20:37
@yoavkatz
yoavkatz merged commit fa5c27d into rossoctl:main Jul 21, 2026
1 check passed
@yoavkatz

Copy link
Copy Markdown
Contributor

I merged the changes. I think adding --namespace argument makes sense.

yoavkatz added a commit to yoavkatz/workload-harness that referenced this pull request Jul 21, 2026
…ride

Resolve conflicts in deploy-agent.sh and deploy-benchmark.sh by combining
the experiment-suffix block from this branch with NAMESPACE="${NAMESPACE:-team1}"
from rossoctl/main (PR rossoctl#35), so both features coexist.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants