fix: Point pr-review-scanner at rossoctl repo names#34
Open
rubambiza wants to merge 1 commit into
Open
Conversation
gh pr list --repo follows org renames for bare listing but SILENTLY drops results when combined with --label (and --author) filters. The scanner's hardcoded kagenti/* REPOS array therefore matched zero labeled PRs after the rename, so ready-for-ai-review PRs were skipped without any error. Point REPOS at the canonical rossoctl/* names (kagenti->rossoctl, kagenti-extensions->cortex) so the label query resolves again. Verified: a labeled PR that returned 0 under the old names is now found and marked eligible. Minimal interim fix; the full allowlist-driven enumeration lands in a later change. Part of rossoctl#32. Assisted-By: Claude Code (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
rubambiza
added
the
ready-for-ai-review
clawgenti
reviewed
Jul 23, 2026
clawgenti
left a comment
clawgenti
left a comment
There was a problem hiding this comment.
Targeted rename of hardcoded kagenti/* repo names to their canonical rossoctl/* equivalents in pr-review-scanner.sh, including the in-file comment example. Fixes the silent --label filter failure caused by GitHub not forwarding filtered gh pr list queries through the org redirect.
All checks pass. Ready for human review.
Reviewed by clawgenti using github:pr-review
rubambiza
added
ready-for-human-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh pr list --repo <renamed-repo>follows the org rename for a bare listing, but silently drops results when the query is combined with a--label(or--author) filter. Becausepr-review-scanner.shhardcoded the oldkagenti/*repo names, its--label ready-for-ai-reviewquery returned zero matches after the rename — so labeled PRs were skipped with no error and never queued for review.This points
REPOSat the canonicalrossoctl/*names (kagenti→rossoctl,kagenti-extensions→cortex), which restores the label query.Why separate from the search-restore fix
This is a distinct failure mode from the search-based one (
gh api search/issues422 vs.gh pr listfiltered-redirect drop) and touches a different file, so it is isolated here for a clean, revertible change.Verification
Scope / follow-up
Minimal interim fix. The full allowlist-driven enumeration (a shared
core-reposlist read by all programs, replacing hardcoded arrays) lands in a later change tracked under the epic.dep-bump-scanner.shhas the same class of bug via--author "app/dependabot"; it is deferred to that allowlist change because it also requires resolving duplicate local clones.Part of #32.
Assisted-By: Claude Code