Added support for internal and public Navidrome address#74
Open
daylight-roberty wants to merge 1 commit into
Open
Added support for internal and public Navidrome address#74daylight-roberty wants to merge 1 commit into
daylight-roberty wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey I really appreciate your work on this, super tidy and well documented
To get it going in my environment I had to set a different Navidrome URL for AskNavidrome (LAN) and Alexa (WAN), so I added optional parameters for a public URL and port. If the new parameters are not provided it uses the current values by default to make it backwards-compatible with docker-compose
I also added a parameter to optionally set a base path for AskNavidrome requests. This allows forwarding of requests to either Navidrome or AskNavidrome based the URL, eg
https://navidrome.my-domain.com/alexa/goes to AskNavidrome andhttps://navidrome.my-domain.comgoes to NavidromeThe given base path is stripped of all leading
/'s with a single/stuck to the beginning, soalexa,/alexaand////alexaeach become/alexaand an empty value becomes the default/Hope this makes sense! Cheers