Fix double-click open and polish titlebar/properties icons - #7
Merged
Conversation
Double-click on PDF/HTML and other files no longer loses to drag arming: the second tap at the same spot within 450ms suppresses DoDragDrop so Slint can emit double-clicked reliably. Titlebar maximize uses Win11-style square/restore glyphs that swap with window_maximized state, synced on toggle and OS resize events. Properties uses a consistent document-with-metadata icon in the context menu and selection bar. Storage rows also accept double-click to open. Co-authored-by: rorohecker <rorohecker@users.noreply.github.com>
Remove redundant StorageEntryRow double-click handler (single-click already opens; Slint would fire clicked twice plus double-clicked). Add double-click on the titlebar drag strip to toggle maximize like native Windows. Co-authored-by: rorohecker <rorohecker@users.noreply.github.com>
Merge mouse side-button navigation and maximize-state sync into one on_winit_window_event callback so the second registration no longer drops back/forward handling. Optimistically flip window_maximized on button click and align FileRow double-click timing to 500ms. Co-authored-by: rorohecker <rorohecker@users.noreply.github.com>
Co-authored-by: rorohecker <rorohecker@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/fix-double-click-ui-polish-a90e
branch
from
September 2, 2026 16:32
4426cf4 to
fecb5f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
double-clicked, startingDoDragDropinstead of opening the file. File rows now track recent click position and suppress drag arming when the next press lands at the same spot within ~450ms.window_maximizedstate, synced on button click and OS resize events.Test plan