v1.0.4: prevent OneDrive hydration from background file reads - #6
Merged
Conversation
Background thumbnail generation, search indexing (dHash and image tags), and previews were reading file bodies under OneDrive and other sync folders, which hydrates online-only placeholders and triggers downloads. Detect Windows cloud placeholder attributes before any content read and skip hydration-risk paths. Opening Settings via the gear icon now routes through the settings command so AI status refreshes on open. Co-authored-by: rorohecker <rorohecker@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pathfinder was triggering unexpected downloads from Personal OneDrive (and other cloud sync providers) because background work read file bodies for:
Reading an online-only placeholder hydrates it in OneDrive.
Fix
cloud_files::hydration_risk()— checks WindowsFILE_ATTRIBUTE_OFFLINE,RECALL_ON_OPEN, andRECALL_ON_DATA_ACCESSbefore any content readcommand("settings")so AI capabilities refresh when opening Settings (small related fix)Notes
Version: 1.0.4