Repository navigation
Fix native recording lifecycle - #2
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
roprgm
marked this pull request as ready for review
July 25, 2026 19:38
roprgm
force-pushed
the
agent/fix-native-recording-lifecycle
branch
from
July 25, 2026 20:06
890642e to
3557284
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The native adapter used a separate microphone stream for the waveform while the provider inferred recording state from the transcription object. A recognition service could therefore end while the waveform UI remained active. The provider also handled only rejected final-text promises, and the native adapter treated every recognition error as fatal even after valid text had been emitted.
Behavior
audiostartbefore reporting recordingcaptureEndedso recording visuals stop during final-text processingValidation
pnpm test— 41 tests passedpnpm checkpnpm build