Align docs and behavior: address purpose, empty results, validation#85
Closed
frankfarach wants to merge 6 commits into
Closed
Align docs and behavior: address purpose, empty results, validation#85frankfarach wants to merge 6 commits into
frankfarach wants to merge 6 commits into
Conversation
Accept case-insensitive address_purpose values and normalize to API constants; add unit test for secondary -> SECONDARY.
Allow vector inputs and return logical vectors; add tests for vector validation.
Return a structured npi_results for zero-record searches; keep npi column integer for consistent binding; update empty-result test.
Clarify that npi_summarize falls back to the first taxonomy when no primary is marked; update README and Rd docs.
Document recent changes in NEWS and refresh roxygen output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
address_purposeinputs to the API’s uppercase values and add test coverage.npi_resultsobject for zero‑record searches.npi_is_valid()to accept multiple NPIs.npi_summarizedocs andREADME.Changes
npi_search()accepts case‑insensitive address_purpose and normalizes toLOCATION/MAILING/PRIMARY/SECONDARY.npi_search()returns a structured empty npi_results instead of bare tibble().npi_is_valid()now accepts vectors and returns a logical vector.Testing
Notes