Repository navigation
ci: drop dependency install from setup job and keep main runs - #2644
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying portfolio with
|
| Latest commit: |
6a47c50
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bcd984bd.portfolio-6od.pages.dev |
| Branch Preview URL: | https://ci-lighten-setup-job.portfolio-6od.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the
setupjob lighter and stop cancelling in-progress CI runs onmain.Motivation
setupjob ran the fullsetup-environmentaction (Bun setup and cache restore) only to rundorny/paths-filter, which needs no dependencies.cancel-in-progress: truealso applied tomain, so merging several PRs in a row cancelled the earlier runs.Changes
Initializestep from thesetupjob.checkoutstays, because onpushthe filter reads the git diff.cancel-in-progressto${{ github.ref != 'refs/heads/main' }}. Runs on pull request branches are still cancelled by newer pushes.Testing
bun run format,lint:dprint,lint:oxfmt)Setupcompletes withoutInitializeandGatekeeperdoes not failmainno longer cancel each otherNotes
Only
ci.ymlchanges here, so it matches no path filter andBuildandLintare expected to be skipped on this PR. Theconcurrencychange can only be observed onmainafter merging.🤖 Generated with Claude Code