Skip to content

ci: Update Merge Gatekeeper condition for job execution #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roottool merged 2 commits into from
Jul 19, 2026
Merged

ci: Update Merge Gatekeeper condition for job execution #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad89714
ci: Update Merge Gatekeeper condition for job execution
roottool Jul 19, 2026
dfc5a07
ci: Revert shell lint steps to find-based file discovery
roottool Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:
markdown: ${{ steps.filter.outputs.markdown }}
markdown_files: ${{ steps.filter.outputs.markdown_files }}
shellscript: ${{ steps.filter.outputs.shellscript }}
shellscript_files: ${{ steps.filter.outputs.shellscript_files }}
if: ${{ !github.event.pull_request.draft }}
steps:
- name: Assign yourself to this PR
Expand Down Expand Up @@ -51,7 +50,6 @@ jobs:
- 'dot_profile'
- 'dot_zprofile'
- 'dot_zsh*'
- '!examples/**'

lint:
name: Lint
Expand All @@ -71,14 +69,10 @@ jobs:
- parallel:
- name: Check formatting (shfmt)
if: ${{ needs.setup.outputs.shellscript == 'true' }}
env:
SHELLSCRIPT_FILES: ${{ needs.setup.outputs.shellscript_files }}
run: shfmt -d $SHELLSCRIPT_FILES
run: find . -type f \( -name 'dot_profile' -o -name 'dot_z*' -o -name '*.sh' -o -name '*.zsh' \) | grep -Ev 'examples/*' | xargs shfmt -d
- name: ShellCheck
if: ${{ needs.setup.outputs.shellscript == 'true' }}
env:
SHELLSCRIPT_FILES: ${{ needs.setup.outputs.shellscript_files }}
run: shellcheck $SHELLSCRIPT_FILES
run: find . -type f \( -name 'dot_profile' -o -name 'dot_z*' -o -name '*.sh' -o -name '*.zsh' \) | grep -Ev 'examples/*' | xargs shellcheck
- name: Markdown lint
if: ${{ needs.setup.outputs.markdown == 'true' }}
uses: DavidAnson/markdownlint-cli2-action@8de2aa07cae85fd17c0b35642db70cf5495f1d25 # v24.0.0
Expand All @@ -103,7 +97,6 @@ jobs:
runs-on: ubuntu-slim
timeout-minutes: 2
needs: [test]
if: ${{ !(failure() || contains(needs.*.result, 'cancelled')) }}
if: always() && (contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled'))
steps:
- name: Exit with success
run: exit 0
- run: exit 1