Repository navigation
ci: Add shfmt formatting check for shell scripts - #70
Merged
Merged
Conversation
Pairs shfmt with the existing ShellCheck lint step so shell/zsh files follow a consistent style enforced in CI, honoring the repo's .editorconfig indent settings automatically. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Pairs shfmt with the existing ShellCheck lint step so shell/zsh files follow a consistent style enforced in CI, honoring the repo's .editorconfig indent settings automatically. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
roottool
enabled auto-merge (squash)
July 19, 2026 06:16
Fixes shellscript_files output referencing the boolean output instead of the file list, avoids splicing PR-controlled filenames directly into run: scripts by passing them via env, and makes the examples/ exclusion recursive to match the previous grep-based behavior. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shfmtformatting check to the CIlintjob, pairing it with the existing ShellCheck step so shell/zsh files follow a consistent style.shfmtpicks up indent settings automatically from the repo's.editorconfig(2-space indent), so no extra formatter config is needed.shfmtto theBrewfilefor local use, and reformatinstall-packages.sh(the one file that wasn't already compliant) so CI starts green.Test plan
shfmt -dlocally against all files targeted by the lint job (dot_z*,*.sh,*.zsh) and confirmed a clean diff after formattinginstall-packages.sh.Setup shfmt/Check formatting (shfmt)steps pass in CI.🤖 Generated with Claude Code