Skip to content

ci: change some ci settings #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roottool merged 2 commits into from
Jul 19, 2026
Merged

ci: change some ci settings #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59928e5
ci: convert `types` format
roottool Jul 19, 2026
4ce2c99
ci: Update settings
roottool Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/assign.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ name: "Auto Assign"
run-name: "${{ github.workflow }} (${{ github.ref_name }}): ${{ github.event.pull_request.title }}"
on:
pull_request:
types:
- opened
- reopened
- ready_for_review
types: [opened, reopened, ready_for_review]

permissions: {}

defaults:
run:
Expand Down
33 changes: 10 additions & 23 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ defaults:
jobs:
setup:
name: Setup
runs-on: ubuntu-latest
runs-on: ubuntu-slim
timeout-minutes: 5
permissions:
pull-requests: write
Expand Down Expand Up @@ -44,25 +44,6 @@ jobs:
markdown:
- '**/*.md'

markdown-lint:
name: Markdown lint
runs-on: ubuntu-latest
timeout-minutes: 5
needs: [setup]
if: ${{ needs.setup.outputs.markdown == 'true' }}
steps:
- name: Checkout Repository
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: false
sparse-checkout: |
${{ needs.setup.outputs.markdown_files }}
sparse-checkout-cone-mode: false
- name: Lint
uses: DavidAnson/markdownlint-cli2-action@8de2aa07cae85fd17c0b35642db70cf5495f1d25 # v24.0.0
with:
globs: ${{ needs.setup.outputs.markdown_files }}

lint:
name: Lint
runs-on: ubuntu-latest
Expand All @@ -73,8 +54,14 @@ jobs:
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: false
- name: ShellCheck
run: find . -type f \( -name 'dot_z*' -o -name '*.sh' -o -name '*.zsh' \) | grep -Ev 'examples/*' | xargs shellcheck
- parallel:
- name: ShellCheck
run: find . -type f \( -name 'dot_z*' -o -name '*.sh' -o -name '*.zsh' \) | grep -Ev 'examples/*' | xargs shellcheck
- name: Markdown lint
if: ${{ needs.setup.outputs.markdown == 'true' }}
uses: DavidAnson/markdownlint-cli2-action@8de2aa07cae85fd17c0b35642db70cf5495f1d25 # v24.0.0
with:
globs: ${{ needs.setup.outputs.markdown_files }}

test:
name: Test
Expand All @@ -93,7 +80,7 @@ jobs:
name: Merge Gatekeeper
runs-on: ubuntu-slim
timeout-minutes: 2
needs: [markdown-lint, test]
needs: [test]
if: ${{ !(failure() || contains(needs.*.result, 'cancelled')) }}
steps:
- name: Exit with success
Expand Down